feat(cloudflare): add support for MX records #5283

arthlr · 2025-04-13T09:06:14Z

Hi there! 👋

Description

This PR introduces support for MX records for the Cloudflare provider.

Cloudflare can now manage MX records via the DNSEndpoint CRD.
Adds logic to parse MX records and extract priority and mail host
Extends unit tests to validate proper MX record creation and priority
Updates the documentation to reflect support for cloudflare in MX record management.

Fixes #5282

Checklist

Unit tests updated
End user documentation updated (docs/sources/mx-record.md)

Thanks for checking this out! 🙏
Looking forward to your feedback — happy to make any changes if needed.

k8s-ci-robot · 2025-04-13T09:06:23Z

Hi @arthlr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mloiseleur · 2025-04-13T14:55:24Z

/ok-to-test
@AndrewCharlesHay @mrozentsvayg do you think you can review this PR ?

registry/txt.go

arthlr · 2025-04-13T19:22:47Z

/retest

provider/cloudflare/cloudflare.go

mrozentsvayg · 2025-04-14T16:29:28Z

registry/txt.go

Not sure about the idea to use txt registry for the txt records.
If it's not an integral part of the PR, i would postpone it until we better understand the txt registry roadmap, especially the part of deprecating old records.

I'll remove it then 👍
However, we'll need it one day (I would like to use MX and TXT records to automatically deploy sengrid-like DNS records)

using the TXT registry, specifically?

Yes, I am not using AWS and still don't want a noop registry.
Then, a TXT registry, to store the metadata of TXT records created by external-dns is must-have for my team and I.

endpoint/endpoint.go

provider/cloudflare/cloudflare.go

mloiseleur · 2025-05-28T20:34:24Z

@mrozentsvayg anything left on your side ?
@AndrewCharlesHay any comments on this PR ?

provider/cloudflare/cloudflare.go

mloiseleur · 2025-06-05T14:27:58Z

@mrozentsvayg @AndrewCharlesHay anything left for you ?

endpoint/endpoint.go

Signed-off-by: Arthur Le Roux <[email protected]>

…ferences Signed-off-by: Arthur Le Roux <[email protected]>

…accordingly Signed-off-by: Arthur Le Roux <[email protected]>

…able declarations Signed-off-by: Arthur Le Roux <[email protected]>

…struct fields and add missing test case for host validation Signed-off-by: Arthur Le Roux <[email protected]>

…ling and ensuring proper priority and host retrieval Signed-off-by: Arthur Le Roux <[email protected]>

…ewMXTarget to use them Signed-off-by: Arthur Le Roux <[email protected]>

… use provider methods and enhance MX record handling in tests Signed-off-by: Arthur Le Roux <[email protected]>

Signed-off-by: Arthur Le Roux <[email protected]>

… update references Signed-off-by: Arthur Le Roux <[email protected]>

docs/sources/mx-record.md

Co-authored-by: Michel Loiseleur <[email protected]>

ivankatliarchuk

/lgtm

cc @mloiseleur

k8s-ci-robot · 2025-06-24T06:30:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ivankatliarchuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ivankatliarchuk · 2025-06-24T06:59:17Z

I forget that if I approve on review, it adds auto-approval.

* feat(cloudflare): add support for MX records Signed-off-by: Arthur Le Roux <[email protected]> * test(txt): add additional TXT and MX record test cases Signed-off-by: Arthur Le Roux <[email protected]> * feat(endpoint): implement parsing for MX and SRV records with structured targets Signed-off-by: Arthur Le Roux <[email protected]> * fix(txt): remove TXT record type from supported types in NewTXTRegistry Signed-off-by: Arthur Le Roux <[email protected]> * refactor(digitalocean): streamline MX record handling Signed-off-by: Arthur Le Roux <[email protected]> * refactor(cloudflare): improve error handling in change creation Signed-off-by: Arthur Le Roux <[email protected]> * fix(endpoint): return all parsed SRV targets instead of a single target Signed-off-by: Arthur Le Roux <[email protected]> * test(endpoint): add parsing tests for MX and SRV records Signed-off-by: Arthur Le Roux <[email protected]> * fix(endpoint): streamline MX and SRV record validation and parsing Signed-off-by: Arthur Le Roux <[email protected]> * fix(digital_ocean): simplify MX record parsing Signed-off-by: Arthur Le Roux <[email protected]> * fix(docs): update link to CRD source in MX record documentation Signed-off-by: Arthur Le Roux <[email protected]> * fix(cloudflare): improve error handling for MX record parsing Signed-off-by: Arthur Le Roux <[email protected]> * fix(cloudflare): improve error message formatting for MX record parsing Signed-off-by: Arthur Le Roux <[email protected]> * refactor(endpoint): rename ParseMXRecord to NewMXTarget and update references Signed-off-by: Arthur Le Roux <[email protected]> * fix(endpoint): update NewMXTarget to return pointer and adjust tests accordingly Signed-off-by: Arthur Le Roux <[email protected]> * refactor(cloudflare): consolidate proxyEnabled and proxyDisabled variable declarations Signed-off-by: Arthur Le Roux <[email protected]> * fix(endpoint): update TestNewMXTarget to reflect changes in MXTarget struct fields and add missing test case for host validation Signed-off-by: Arthur Le Roux <[email protected]> * fix(digitalocean): improve MX record handling by adjusting error handling and ensuring proper priority and host retrieval Signed-off-by: Arthur Le Roux <[email protected]> * refactor(endpoint): change MXTarget fields to unexported and update NewMXTarget to use them Signed-off-by: Arthur Le Roux <[email protected]> * refactor(cloudflare): update groupByNameAndTypeWithCustomHostnames to use provider methods and enhance MX record handling in tests Signed-off-by: Arthur Le Roux <[email protected]> * test(cloudflare): enhance test cover Signed-off-by: Arthur Le Roux <[email protected]> * refactor(endpoint): remove unused SRVTarget struct from endpoint.go Signed-off-by: Arthur Le Roux <[email protected]> * refactor(endpoint): rename NewMXTarget to NewMXRecord for clarity and update references Signed-off-by: Arthur Le Roux <[email protected]> * Update docs/sources/mx-record.md Co-authored-by: Michel Loiseleur <[email protected]> --------- Signed-off-by: Arthur Le Roux <[email protected]> Co-authored-by: Michel Loiseleur <[email protected]>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 13, 2025

k8s-ci-robot requested review from ivankatliarchuk and mloiseleur April 13, 2025 09:06

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2025

mloiseleur reviewed Apr 13, 2025

View reviewed changes

registry/txt.go Outdated Show resolved Hide resolved

arthlr force-pushed the feat/mx-record branch 2 times, most recently from 14185d5 to 4f51703 Compare April 13, 2025 19:08

mrozentsvayg reviewed Apr 14, 2025

View reviewed changes

arthlr force-pushed the feat/mx-record branch from c071624 to 2cc854b Compare April 15, 2025 17:02

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2025

mrozentsvayg reviewed Apr 16, 2025

View reviewed changes

endpoint/endpoint.go Outdated Show resolved Hide resolved

mrozentsvayg reviewed Apr 16, 2025

View reviewed changes

endpoint/endpoint.go Outdated Show resolved Hide resolved

mrozentsvayg reviewed Apr 16, 2025

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2025

arthlr requested a review from mrozentsvayg April 30, 2025 12:01

AndrewCharlesHay reviewed May 28, 2025

View reviewed changes

provider/cloudflare/cloudflare.go Outdated Show resolved Hide resolved

arthlr force-pushed the feat/mx-record branch from 519c016 to a32f388 Compare May 30, 2025 08:40

k8s-ci-robot added docs provider Issues or PRs related to a provider and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 30, 2025

ivankatliarchuk suggested changes Jun 10, 2025

View reviewed changes

endpoint/endpoint.go Outdated Show resolved Hide resolved

endpoint/endpoint.go Outdated Show resolved Hide resolved

endpoint/endpoint.go Outdated Show resolved Hide resolved

arthlr added 17 commits June 23, 2025 14:14

fix(endpoint): return all parsed SRV targets instead of a single target

65e903e

Signed-off-by: Arthur Le Roux <[email protected]>

test(endpoint): add parsing tests for MX and SRV records

bb5a509

Signed-off-by: Arthur Le Roux <[email protected]>

fix(endpoint): streamline MX and SRV record validation and parsing

aab81a7

Signed-off-by: Arthur Le Roux <[email protected]>

fix(digital_ocean): simplify MX record parsing

364f1aa

Signed-off-by: Arthur Le Roux <[email protected]>

fix(docs): update link to CRD source in MX record documentation

5c2c3b9

Signed-off-by: Arthur Le Roux <[email protected]>

fix(cloudflare): improve error handling for MX record parsing

ddda28a

Signed-off-by: Arthur Le Roux <[email protected]>

fix(cloudflare): improve error message formatting for MX record parsing

a63a9b9

Signed-off-by: Arthur Le Roux <[email protected]>

refactor(endpoint): rename ParseMXRecord to NewMXTarget and update re…

cb611d7

…ferences Signed-off-by: Arthur Le Roux <[email protected]>

fix(endpoint): update NewMXTarget to return pointer and adjust tests …

9571205

…accordingly Signed-off-by: Arthur Le Roux <[email protected]>

refactor(cloudflare): consolidate proxyEnabled and proxyDisabled vari…

bd08258

…able declarations Signed-off-by: Arthur Le Roux <[email protected]>

fix(endpoint): update TestNewMXTarget to reflect changes in MXTarget …

58b996b

…struct fields and add missing test case for host validation Signed-off-by: Arthur Le Roux <[email protected]>

fix(digitalocean): improve MX record handling by adjusting error hand…

03b2066

…ling and ensuring proper priority and host retrieval Signed-off-by: Arthur Le Roux <[email protected]>

refactor(endpoint): change MXTarget fields to unexported and update N…

d6ae998

…ewMXTarget to use them Signed-off-by: Arthur Le Roux <[email protected]>

refactor(cloudflare): update groupByNameAndTypeWithCustomHostnames to…

852a53a

… use provider methods and enhance MX record handling in tests Signed-off-by: Arthur Le Roux <[email protected]>

test(cloudflare): enhance test cover

fcd0340

Signed-off-by: Arthur Le Roux <[email protected]>

refactor(endpoint): remove unused SRVTarget struct from endpoint.go

1d7d8e4

Signed-off-by: Arthur Le Roux <[email protected]>

refactor(endpoint): rename NewMXTarget to NewMXRecord for clarity and…

7912f0b

… update references Signed-off-by: Arthur Le Roux <[email protected]>

arthlr force-pushed the feat/mx-record branch from 299aa2a to 7912f0b Compare June 23, 2025 12:15

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2025

mloiseleur reviewed Jun 23, 2025

View reviewed changes

docs/sources/mx-record.md Outdated Show resolved Hide resolved

Update docs/sources/mx-record.md

fa5d134

Co-authored-by: Michel Loiseleur <[email protected]>

ivankatliarchuk approved these changes Jun 24, 2025

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025

k8s-ci-robot merged commit e17b5ed into kubernetes-sigs:master Jun 24, 2025
14 checks passed

zkharit mentioned this pull request Jul 8, 2025

MX record for cloudflare gives error 1004 #4207

Closed

feat(cloudflare): add support for MX records #5283

feat(cloudflare): add support for MX records #5283

Uh oh!

Conversation

arthlr commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Apr 13, 2025

Uh oh!

mloiseleur commented Apr 13, 2025

Uh oh!

Uh oh!

arthlr commented Apr 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrozentsvayg Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

arthlr Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

mrozentsvayg Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

arthlr Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mloiseleur commented May 28, 2025

Uh oh!

Uh oh!

mloiseleur commented Jun 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivankatliarchuk left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jun 24, 2025

Uh oh!

Uh oh!

ivankatliarchuk commented Jun 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

arthlr commented Apr 13, 2025 •

edited

Loading